Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Noetic (and two minor things) #60

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix for Noetic (and two minor things) #60

wants to merge 4 commits into from

Conversation

tkazik
Copy link

@tkazik tkazik commented Jan 13, 2021 •
edited
Loading

  • fixes message generation for Noetic
  • gets rid of FindEigen.cmake deprecated warning (=> Eigen3)
  • increases cmake min req version to get rid of cmake warnings (RSL uses 3.10)

tkazik added 3 commits January 13, 2021 18:18
@tkazik
Fix message_generation for noetic
9748fce 
Build dependency instead of buildtool dependency (viconEstimator.msg was not built)
@tkazik
Updated find_package for Eigen3
64909cd 
Avoids warning "The FindEigen.cmake Module in the cmake_modules package is deprecated." while building
@tkazik
Increase cmake minimum required version
1c73c2a 
This avoids warning ("Policy CMP0048 is not set")
@tkazik tkazik requested a review from alexmillane January 13, 2021 17:38
alexmillane
alexmillane suggested changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@alexmillane alexmillane left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Builds on Melodic for me.

However, we should sort out Jenkins before merging anything.

I'll have a look this evening.

@tkazik
Copy link
Author

tkazik commented Jan 14, 2021

True...I just had a brief look:

  • The handshake with ROVIO's lightweight_filtering on bitbucket fails
  • Bitbucket has updated its cipher support last year (info here)
  • Our trusty friend Jenkins still seems to be on 14.04 (EOL 2019 :)) and this is apparently the issue (old/no longer supported cipher)

Two options:

  • Switch to ssh (Link)
  • Update curl (Link)

Which one do you prefer?

PS: Same Jenkins issue probably also affects #59 and #58 (@rikba)

@alexmillane
Copy link
Contributor

Thanks the info @tkazik!

I see that all of our MAV jenkins jobs pull in all of our deps, of which lightweight_filtering (through rovio) is one. So I guess 100% of our buildjobs are broken right now.

To confirm this I manually triggered a job for rovio (hasn't been built on jenkins in over a year) and sure enough it fails: https://jenkins.asl.ethz.ch/job/rovio/label=ubuntu/116/

I'm thinking that surely we have a 16.04 Jenkins slave? surely?!

I'm clocking off for tonight though.

@tkazik
Updated README
c377e9c 
Added build status, replaced dead UNC-url & editorial changes
@tkazik
Copy link
Author

tkazik commented Jan 15, 2021

Yes, I think that currently all build jobs that include ROVIO and are executed by Jenkins on a 14.04/Trusty are broken. So there are some more options (besides the two above):

  • Assign another/newer node for the build job (there are plenty of other/newer nodes, e.g. this xenial or this bionic). Especially the bionic node seems to have no jobs at all.
  • We could remove the dependency on ROVIO for this package...but I guess it is in the deps for a reason, right?

I added the build status to the README, updated a few links and restructured it a bit...hope you don't mind.

@michaelpantic
Copy link
Member

michaelpantic commented Jan 15, 2021 •
edited
Loading

we should probably kick out all builds for 14.04 (and 16.04?) eventually, not worth spending the time to maintain this stuff

(I estimate we have about 1 user still using them)

@alexmillane
Copy link
Contributor

we should probably kick out all builds for 14.04 (and 16.04?) eventually, not worth spending the time to maintain this stuff

(I estimate we have about 1 user still using them)

Yes but that user is probably the best-looking member of this team.

... but yeah let's kick out 14.04.

@michaelpantic
Copy link
Member

Yes but that user is probably the best-looking member of this team.

hahaha

image

@clanegge
Copy link

Yes but that user is probably the best-looking member of this team.

Nah I am already on 18.04

@tkazik
Copy link
Author

tkazik commented Jan 18, 2021

lol guys, that escalated quickly...how about you ask some "mirror, mirror on the wall?"

Anyway, Jenkins seems to be willing to get some tender loving care (ssh or curl update on 14.04; or rather assign it to a newer node (preferable 18.04)). How do we proceed? I don't have the proper rights for the Jenkins machine...would be happy to look over someone's (virtual) shoulder.

@michaelpantic
Copy link
Member

michaelpantic commented Jan 18, 2021 •
edited
Loading

ssh or curl update on 14.04
hmm I think we shouldnt update this anymore.

I just checked, ros_vrpn_client is not set up as a multi-configuration jekins project, so it doesn't really care where it gets executed and thus may fail sometimes and not some other times.

Proposal: We set it up as a new multi-config project and assign it to right hosts.
@tkazik if you want we can to this together via zoom, e.g. later this week? Let me know by mail!

Edit: first tagged some random github user named Tim :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmillane alexmillane alexmillane requested changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tkazik @alexmillane @michaelpantic @clanegge